Skip to content

revealjs - lift Figure.fragment to surrounding div #12605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025
Merged

Conversation

cscheid
Copy link
Collaborator

@cscheid cscheid commented Apr 23, 2025

Closes #12598.

@cscheid cscheid added this to the v1.8 milestone Apr 23, 2025
@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Apr 23, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR contains some change from another PR 🤔

Probably not a problem but still not cleanest history.

@cscheid
Copy link
Collaborator Author

cscheid commented Apr 29, 2025

that was intentional to make it easier to merge the changelogs (there's a separate PR for that one running), but I guess a rebase would have been cleaner.

@cscheid cscheid merged commit b563f06 into main Apr 29, 2025
49 checks passed
@cscheid cscheid deleted the bugfix/issue-12598 branch April 29, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.fragment on an image with caption should apply to whole figure, not just the img
3 participants