Skip to content

This commit fixes error when updating multiple confluence attachments #13341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

This commit fixes error when updating multiple confluence attachments #13341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions src/publish/confluence/confluence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,15 +435,26 @@ async function publish(
LogPrefix.ATTACHMENT,
);

const uploadAttachmentsResult = await Promise.all(
uploadAttachments(
publishFiles.baseDir,
attachmentsToUpload,
toUpdate.id,
fileName,
existingAttachments,
),
);
const uploadAttachmentsResult: unknown[] = [];

for (const att of attachmentsToUpload) {
// Start exactly ONE upload by calling the helper with a single attachment
const tasks = uploadAttachments(
publishFiles.baseDir,
[att], // <-- one at a time
toUpdate.id,
fileName,
existingAttachments,
) as Promise<unknown>[]; // uploadAttachments returns an array of Promises

const res = await tasks[0];
uploadAttachmentsResult.push(res);

// short backoff (milliseconds)
const t0 = performance.now();
await new Promise<void>(r => setTimeout(r, 800)); // 0.8s
trace("[ATTACHMENT] sleptMs", { ms: Math.round(performance.now() - t0) }, LogPrefix.ATTACHMENT);
}
trace(
"uploadAttachmentsResult",
uploadAttachmentsResult,
Expand Down
Loading