[QEff Finetune]: Implement logger for finetuning and enable dumping #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-mamta
requested review from
quic-swatia and
vbaddi
and removed request for
ochougul and
quic-rishinr
quic-meetkuma
suggested changes
May 12, 2025
quic-meetkuma
suggested changes
May 12, 2025
quic-mamta
force-pushed
the
use_logger
branch
3 times, most recently
from
79a2115 to
2de4c6f
Compare
quic-mamta
force-pushed
the
use_logger
branch
3 times, most recently
from
1fc9ef2 to
f97b24e
Compare
|
@mamtsing can you pls rebase and confirm if this logs file will be stored in the default qeff cache path? |
quic-mamta
force-pushed
the
use_logger
branch
4 times, most recently
from
99eb8ce to
203a358
Compare
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
quic-swatia
reviewed
Jun 30, 2025
Signed-off-by: Mamta Singh <[email protected]>
quic-meetkuma
approved these changes
Jul 9, 2025
quic-mamta
force-pushed
the
use_logger
branch
2 times, most recently
from
7c2787a to
1833204
Compare
quic-swatia
approved these changes
Jul 9, 2025
Signed-off-by: Mamta Singh <[email protected]>
quic-mamta
changed the title
quic-amitraj
pushed a commit
that referenced
this pull request
Jul 10, 2025
…371) 1. Implement logger for finetuning 2. enable dumping logs by given flag --------- Signed-off-by: Mamta Singh <[email protected]> Co-authored-by: Mamta Singh <[email protected]> Signed-off-by: Amit Raj <[email protected]>
quic-amitraj
pushed a commit
that referenced
this pull request
Jul 10, 2025
…371) 1. Implement logger for finetuning 2. enable dumping logs by given flag --------- Signed-off-by: Mamta Singh <[email protected]> Co-authored-by: Mamta Singh <[email protected]> Signed-off-by: Amit Raj <[email protected]>
quic-amitraj
pushed a commit
that referenced
this pull request
Jul 10, 2025
…371) 1. Implement logger for finetuning 2. enable dumping logs by given flag --------- Signed-off-by: Mamta Singh <[email protected]> Co-authored-by: Mamta Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.