Added Prompt length check for VLMs #422
Open
+112
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asmita Goswami <[email protected]>
asmigosw
requested review from
quic-rishinr,
ochougul,
quic-hemagnih and
quic-amitraj
as code owners
QEfficient/cloud/infer.py
Outdated
| f"Increasing increase the prompt length to at least {total_tokens + prompt_len}." | ||
| ) | ||
| prompt_len = total_tokens + prompt_len | ||
| ctx_len = prompt_len + 50 |
There was a problem hiding this comment.
from where this 50 is coming?
Signed-off-by: Asmita Goswami <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompt length needs to be greater than the decoded image tokens + buffer, so in case user passes PL to be less than this value, VLM inference was failing, hence added a check to update the PL and CL accordingly.