Llama4 VLM Continuous Batching Support #510
Open
+144
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
mohiso22
requested review from
quic-rishinr,
ochougul,
quic-hemagnih and
quic-amitraj
as code owners
quic-rishinr
requested changes
Jul 31, 2025
| "chunk_length": prefill_seq_len, | ||
| "chunk_ctx_len": chunk_ctx_len, | ||
| } | ||
| if continuous_batching: |
There was a problem hiding this comment.
nit: Can we update together for prefill and decode on line 985? Do we need 2 separate if conditions?
There was a problem hiding this comment.
Yup not needed, I will do both in one if condition.
| else: | ||
| lang_decode["batch_size"] = kv_cache_batch_size | ||
|
|
||
| lang = [] |
There was a problem hiding this comment.
nit: better to use lang_specialization = [lang_prefill, lang_decode] for better readability
| @@ -969,18 +998,22 @@ def get_specializations( | |||
| specializations["lang"] = lang | |||
| return specializations, compiler_options | |||
| else: | |||
| lang[0].pop("vision_size") | |||
There was a problem hiding this comment.
better to use a loop and do the pop operation rather than performing it for each index
| @@ -637,6 +639,9 @@ def export( | |||
| export_dir, | |||
| ) | |||
|
|
|||
| import ipdb | |||
|
please add tests for CB and update the table in validated model list with CB support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.