Fix for kernel 4.2: don't use 64 bits syscalls/types #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently Linux kernel version supported by qemu is based on upstream kernel 4.2 [1]. However, the 64 bits syscalls from musl are not implemented by Hexagon kernel 4.2. And the time_t type is now 64 bits for all archs on musl (not only the 64 bits archs), so we also need to force our own type size here for kernel 4.2. Furthermore, we need to refrain from using faccessat2, as this was only added at kernel 5.8. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/bcain/linux.git/log/?h=bcain/boot_qemu Signed-off-by: Matheus Tavares Bernardino <[email protected]>
|
This provides compatibility with 4.2 and doesn't introduce problems when building with/for 6.x? Is this statement true? The linux userspace programs built with this new musl will work well when using If it's not the case maybe we want an |
AFAICT this is the case - I ran some tests this weekend with this |
androm3da
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently Linux kernel version supported by qemu is based on upstream kernel 4.2 1.
However, the 64 bits syscalls from musl are not implemented by Hexagon kernel 4.2. And the time_t type is now 64 bits for all archs on musl (not only the 64 bits archs), so we also need to force our own type size here for kernel 4.2.
Furthermore, we need to refrain from using faccessat2, as this was only added at kernel 5.8.