Term and IndexingTerm cleanup #2750
Open
+144
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz-dd
force-pushed
the
split_term
branch
from
68b68f2 to
45e531f
Compare
fulmicoton
approved these changes
Dec 1, 2025
Collaborator
fulmicoton
left a comment
fulmicoton
left a comment
There was a problem hiding this comment.
@PSeitz approved. Can you make sure to open a PR with the quickwit update rapidly after merging this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace serialized field with proper
Fieldin Term.mark
Term::serialized_termandTerm::wrapas deprecated (to make the transition smooth: used in Quickwit)add
SerializeDeserializetoTermRemove unused type tag in IndexingTerm (saves 1 byte per term in the termmap)
remove generic in
Termand use derives instead of manual implsfix: use IndexingTerm in postings_writer.rs