Optimize group by for single partition topics #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovv
changed the title
ovv
force-pushed
the
quent/single-partition-groupby
branch
from
85cf8af to
87f2af7
Compare
Group by operations on topics with a single partition are now optimized to avoid creating a repartition topic. Instead, the messages are directly transformed to use the new key, as all messages go to the same partition.
ovv
force-pushed
the
quent/single-partition-groupby
branch
from
87f2af7 to
5999c3a
Compare
gwaramadze
reviewed
Apr 17, 2025
gwaramadze
approved these changes
Apr 21, 2025
daniil-quix
reviewed
Apr 30, 2025
Comment on lines
+633
to
+638
| groupby_sdf = self.__dataframe_clone__( | ||
| stream=stream, stream_id=f"{self.stream_id}--groupby--{operation}" | ||
| ) | ||
| self._registry.register_groupby( | ||
| source_sdf=self, new_sdf=groupby_sdf, register_new_root=False | ||
| ) |
There was a problem hiding this comment.
I'm not sure we even need .register_groupby() here since the operation doesn't create a new topic.
We can treat it as a stateless operation, and keep the same stream_id too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group by operations on topics with a single partition are now optimized to avoid creating a repartition topic. Instead, the messages are directly transformed to use the new key, as all messages go to the same partition.