Skip to content

Commit

Permalink
Build: Pin dev dependencies
Browse files Browse the repository at this point in the history
Follows-up 06424ba. This ensures
reproducible builds for e.g. minor changes in Rollup or Babel.

Also remove the file trigger from `.github/workflows/reproducible.yaml`
which otherwise triggers on release commits and release branches,
because it seems GitHub interprets release branches/tags as creating
all files, and thus matching all files.
  • Loading branch information
Krinkle committed Nov 4, 2024
1 parent 0900773 commit 54a71e4
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 24 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/reproducible.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ on:
- cron: '30 0 * * 1'
# Or manually
workflow_dispatch:
# Or when developing this workflow
push:
paths:
- .github/workflows/reproducible.yaml

jobs:
run:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Foundation's [CLA for QUnit](https://cla.js.foundation/qunitjs/qunit).

For code changes, you'll need to have [Node.js](https://nodejs.org/en/) installed.

Install dependencies in the repository via `npm ci`. Make your code
Install dependencies in the repository via `npm install`. Make your code
changes and run `npm test` which will validate the syntax and coding style,
and run unit and integration tests.

Expand Down
2 changes: 1 addition & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Ensure that all changes for this release have been merged into the main branch.

1. Install dev dependencies:
```
npm ci
npm install
```

1. Prepare for the release commit, and build release artefacts:
Expand Down
3 changes: 1 addition & 2 deletions build/reproducible-builds.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ async function buildRelease (version, cacheDir = null) {
QUNIT_BUILD_RELEASE: '1',
PUPPETEER_CACHE_DIR: path.join(cacheDir, 'puppeteer_download')
};
// Use sync for npm-ci to avoid concurrency bugs with shared cache
cp.execFileSync('npm', ['ci'], {
cp.execFileSync('npm', ['install'], {
env: npmEnv,
cwd: gitDir
});
Expand Down
30 changes: 15 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,14 @@
"tiny-glob": "0.2.9"
},
"devDependencies": {
"@babel/core": "^7.24.6",
"@babel/plugin-external-helpers": "^7.24.6",
"@babel/preset-env": "^7.24.6",
"@babel/core": "7.25.2",
"@babel/plugin-external-helpers": "7.25.9",
"@babel/preset-env": "7.25.4",
"@qunitjs/browserstack-runner": "0.9.5-qunitjs.2",
"@rollup/plugin-babel": "^6.0.4",
"@rollup/plugin-commonjs": "^26.0.1",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-replace": "^5.0.5",
"@rollup/plugin-babel": "6.0.4",
"@rollup/plugin-commonjs": "26.0.1",
"@rollup/plugin-node-resolve": "15.2.3",
"@rollup/plugin-replace": "5.0.7",
"benchmark": "2.1.4",
"eslint": "^8.57.0",
"eslint-config-semistandard": "^17.0.0",
Expand All @@ -82,18 +82,18 @@
"eslint-plugin-qunit": "^8.1.1",
"fixturify": "^3.0.0",
"fuzzysort": "1.2.1",
"grunt": "^1.6.1",
"grunt-contrib-connect": "^5.0.0",
"grunt-contrib-copy": "^1.0.0",
"grunt": "1.6.1",
"grunt-contrib-connect": "5.0.0",
"grunt-contrib-copy": "1.0.0",
"grunt-contrib-qunit": "^10.1.1",
"grunt-search": "^0.1.8",
"grunt-search": "0.1.8",
"kleur": "4.1.5",
"npm-reporter": "file:./test/cli/fixtures/npm-reporter",
"nyc": "^17.0.0",
"proxyquire": "^2.0.0",
"requirejs": "^2.3.6",
"rollup": "^4.18.0",
"tap-min": "^3.0.0"
"proxyquire": "2.1.3",
"requirejs": "2.3.7",
"rollup": "4.21.3",
"tap-min": "3.0.0"
},
"scripts": {
"build": "rollup -c && grunt copy",
Expand Down
2 changes: 1 addition & 1 deletion test/benchmark/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The default is to benchmark the local development version of QUnit.

* Install QUnit for development and generate the release artefact:
```
qunit$ npm ci
qunit$ npm install
qunit$ npm run build
```
* Link benchmark to local artefact.
Expand Down

0 comments on commit 54a71e4

Please sign in to comment.