-
Notifications
You must be signed in to change notification settings - Fork 780
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HTML Reporter: Move internal
urlparams
import out of html.js
As prep to extract a reporter-agnostic "HTML Runner" from the HTML Reporter, move the `urlparams.js` import out of html.js. It is important (and covered by `test/reporter-html/hidepassed.html`) that the `QUnit.begin()` callback in urlparams.js continues to run before the one in html.js. When only moving the import statement, this breaks because diff.js was also importing html.js for re-use of the `escapeText` function. As such the order in reporter.js was not what it appeared. It appeared as: - fixture - diff - html - urlparams But was actually: - fixture - diff - html - urlparams - html (redundant) Ref #1118
- Loading branch information
Showing
4 changed files
with
25 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import './fixture'; | ||
import './diff'; | ||
import './urlparams'; | ||
import './html'; |