Skip to content

Error when linting fails #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Error when linting fails #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
193251a
When linting fails, error instead of quitting
hadley May 25, 2022
cd8ba01
Default LINTR_ERROR_ON_LINT to true
hadley May 25, 2022
f1692fe
Move stop() call back to correct place
hadley May 25, 2022
8888fab
Merge branch 'main' into lint-error
IndrajeetPatil Jun 29, 2022
b799507
Merge branch 'main' into lint-error
IndrajeetPatil Jul 27, 2022
6a8725d
Merge branch 'main' into lint-error
IndrajeetPatil Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion R/methods.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,20 @@ print.lints <- function(x, ...) {
}

if (isTRUE(settings$error_on_lint)) {
quit("no", 31L, FALSE) # nocov
stop(sprintf(
ngettext(length(x),
"Linting failed with %i issue",
"Linting failed with %i issues"
), length(x)
), call. = FALSE)
}

} else if (use_rstudio_source_markers) {
# Empty lints: clear RStudio source markers
rstudio_source_markers(x)
}


invisible(x)
}

Expand Down
2 changes: 1 addition & 1 deletion R/zzz.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ settings <- NULL
"n71nn28")
, 54L - 13L),
comment_bot = logical_env("LINTR_COMMENT_BOT") %||% TRUE,
error_on_lint = logical_env("LINTR_ERROR_ON_LINT") %||% FALSE
error_on_lint = logical_env("LINTR_ERROR_ON_LINT") %||% TRUE
)

settings <<- list2env(default_settings, parent = emptyenv())
Expand Down