Skip to content

Logic to make linters robust to adversarial comments #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Jul 26, 2025

Split of from #2899. Progress on #2737.

I tried to include here those linters that only fail under "adversarial" commenting, which is a bit subjective, the idea is to basically only consider cases of comments that are not particularly common in practice. In practice that means those listed in the NEWS on #2899 without an associated issue.

@MichaelChirico MichaelChirico marked this pull request as ready for review July 26, 2025 21:21
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.28%. Comparing base (84d3f8c) to head (4bee164).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2901   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files         129      129           
  Lines        7266     7282   +16     
=======================================
+ Hits         7214     7230   +16     
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico MichaelChirico added this to the 3.3.0 milestone Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants