Skip to content

ci: Fix comment - #824

Merged
krlmlr merged 1 commit into
mainfrom
actions-sync-update
Jan 13, 2026
Merged

ci: Fix comment#824
krlmlr merged 1 commit into
mainfrom
actions-sync-update

Conversation

@krlmlr

@krlmlr krlmlr commented Jan 13, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings January 13, 2026 06:55
@krlmlr
krlmlr enabled auto-merge (squash) January 13, 2026 06:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix a comment in the R-CMD-check GitHub Actions workflow that describes when the versions-matrix step should run. The original comment incorrectly stated that the step should NOT run when the branch name starts with "cran-", but the actual code logic shows it SHOULD run in that case.

Changes:

  • Updated comment to correctly indicate that the step runs for pull requests when the branch name starts with "cran-"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +137 to +138
# - pull requests if the base repo is different from the head repo
# - pull requests if the branch name starts with "cran-"

Copilot AI Jan 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is still inaccurate. The actual logic on line 142 uses OR conditions, not separate scenarios. For pull requests, the step runs if EITHER the repos are different OR the branch name starts with "cran-", not both conditions separately. Consider revising to: "- pull requests if the base repo is different from the head repo OR the branch name starts with 'cran-'"

Suggested change
# - pull requests if the base repo is different from the head repo
# - pull requests if the branch name starts with "cran-"
# - pull requests if the base repo is different from the head repo OR the branch name starts with "cran-"

Copilot uses AI. Check for mistakes.
@krlmlr
krlmlr merged commit 4fe3148 into main Jan 13, 2026
11 of 12 checks passed
@krlmlr
krlmlr deleted the actions-sync-update branch January 13, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants