Skip to content

Use pkgcache #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use pkgcache #354

wants to merge 4 commits into from

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 24, 2023

No description provided.

gaborcsardi
gaborcsardi reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

@hadley
Copy link
Member Author

hadley commented Jan 24, 2023

One problem is that cache$revdeps() includes the packages as their own dependencies, and in the multipackage case, you can't just setdiff() because (e.g.) if you're checking all the revdeps of dplyr and tidyr, you want to include tidyr because it depends on dplyr.

@MLopez-Ibanez MLopez-Ibanez mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi gaborcsardi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @gaborcsardi