Add allow_na to check_logical()
#1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this finishes everything for r-lib#1724. The rest was fixed in r-lib#1742. A separate PR, r-lib#1745, additionally adds `allow_empty`, but I wanted to leave that out of this to make it easier to review the one small, relevant change. I didn't add add anything to NEWS.md, since the standalone kinda has its own news. I'm not sure if it would be better to also mention is in the main NEWS.md to make it more visible. Fixes r-lib#1724.
lionel-
reviewed
Sep 19, 2025
| @@ -1,462 +1,3 @@ | |||
| # `check_bool()` checks | |||
There was a problem hiding this comment.
It looks like something went wrong with these snapshots
There was a problem hiding this comment.
Gah, seeing why that might have happened. I think I might have been out of sync with main after looking at the other PR near this.
There was a problem hiding this comment.
Sorry about that. Re-running that test fixed the snap.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this finishes everything for #1724. The rest was fixed in #1742. A separate PR, #1745, additionally adds
allow_empty, but I wanted to leave that out of this to make it easier to review the one small, relevant change.I didn't add add anything to NEWS.md, since the standalone kinda has its own news. I'm not sure if it would be better to also mention is in the main NEWS.md to make it more visible.
Fixes #1724.