Fix the issue where timeout failure is not counted as failure in stat…

…istics. (#96)
r12f · Aug 9, 2021 · f00c984 · f00c984
1 parent 4387546
commit f00c984
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 10 deletions.
diff --git a/src/ping_result_processors/ping_result_processor_console_logger.rs b/src/ping_result_processors/ping_result_processor_console_logger.rs
@@ -71,9 +71,10 @@ impl PingResultProcessorConsoleLogger {
         }
 
         self.ping_count += 1;
-        match ping_result.error() {
-            Some(_) => self.failure_count += 1,
-            None => self.success_count += 1,
+        if ping_result.is_succeeded() {
+            self.success_count += 1;
+        } else {
+            self.failure_count += 1;
         }
 
         if let Some(warning) = ping_result.warning() {
@@ -134,7 +135,6 @@ impl PingResultProcessor for PingResultProcessorConsoleLogger {
     fn name(&self) -> &'static str {
         "ConsoleLogger"
     }
-
     fn config(&self) -> &PingResultProcessorCommonConfig {
         self.common_config.as_ref()
     }

diff --git a/src/ping_result_processors/ping_result_processor_csv_logger.rs b/src/ping_result_processors/ping_result_processor_csv_logger.rs
@@ -27,7 +27,6 @@ impl PingResultProcessor for PingResultProcessorCsvLogger {
     fn name(&self) -> &'static str {
         "CsvLogger"
     }
-
     fn config(&self) -> &PingResultProcessorCommonConfig {
         self.common_config.as_ref()
     }

diff --git a/src/ping_result_processors/ping_result_processor_json_logger.rs b/src/ping_result_processors/ping_result_processor_json_logger.rs
@@ -40,7 +40,6 @@ impl PingResultProcessor for PingResultProcessorJsonLogger {
     fn name(&self) -> &'static str {
         "JsonLogger"
     }
-
     fn config(&self) -> &PingResultProcessorCommonConfig {
         self.common_config.as_ref()
     }

diff --git a/src/ping_result_processors/ping_result_processor_latency_bucket_logger.rs b/src/ping_result_processors/ping_result_processor_latency_bucket_logger.rs
@@ -82,7 +82,6 @@ impl PingResultProcessor for PingResultProcessorLatencyBucketLogger {
     fn name(&self) -> &'static str {
         "LatencyBucketLogger"
     }
-
     fn config(&self) -> &PingResultProcessorCommonConfig {
         self.common_config.as_ref()
     }

diff --git a/src/ping_result_processors/ping_result_processor_latency_scatter_logger.rs b/src/ping_result_processors/ping_result_processor_latency_scatter_logger.rs
@@ -57,7 +57,6 @@ impl PingResultProcessor for PingResultProcessorLatencyScatterLogger {
     fn name(&self) -> &'static str {
         "LatencyScatterLogger"
     }
-
     fn config(&self) -> &PingResultProcessorCommonConfig {
         self.common_config.as_ref()
     }

diff --git a/src/ping_result_processors/ping_result_processor_result_scatter_logger.rs b/src/ping_result_processors/ping_result_processor_result_scatter_logger.rs
@@ -47,7 +47,6 @@ impl PingResultProcessor for PingResultProcessorResultScatterLogger {
     fn name(&self) -> &'static str {
         "ResultScatterLogger"
     }
-
     fn config(&self) -> &PingResultProcessorCommonConfig {
         self.common_config.as_ref()
     }

diff --git a/src/ping_result_processors/ping_result_processor_text_logger.rs b/src/ping_result_processors/ping_result_processor_text_logger.rs
@@ -22,7 +22,6 @@ impl PingResultProcessor for PingResultProcessorTextLogger {
     fn name(&self) -> &'static str {
         "TextLogger"
     }
-
     fn config(&self) -> &PingResultProcessorCommonConfig {
         self.common_config.as_ref()
     }