UITableView extension: Completion block for changesets #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This Pull Request introduces previously discussed (and rejected) proposal for addition of completion handlers. The PR does so for UITableView only. The API introduced by this PR is not simple "passing of a closure to the UIKit API." Instead, the API is designed to provide better information about how the changes were handled.
Related Issue
#120
#7
Motivation and Context
I have read the rationale behind rejection. I do think, that this change would simplify the usage of DifferenceKit.
If this PR is not accepted, I would strongly suggest to put the "workaround" from #7 directly into the Xcode markup documentation for related methods.
Impact on Existing Code
API changes additive, ambiguity should not be an issue due to overloading instead of optional parameters.