feat(ironic): manipulate ports only during redfish inspection and not during agent inspection #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haseebsyed12
changed the title
cardoe
requested changes
Nov 20, 2025
components/ironic/values.yaml
Outdated
| redfish: | ||
| # Redfish inspection hooks - keep ports hook to allow port manipulation during redfish inspection | ||
| # Default hooks include: validate-interfaces,ports,architecture | ||
| inspection_hooks: "$default_inspection_hooks,pci-devices,parse-lldp,local-link-connection,resource-class" |
Contributor
There was a problem hiding this comment.
This is a new block. I would drop this because its adding extra hooks for redfish.
Contributor
There was a problem hiding this comment.
So what you have in the PR description is what makes sense to me but that's not what's happening in the code. Dropping this block would make that match.
haseebsyed12
force-pushed
the
skip-port-manipulation-agent-inspect
branch
from
0c3704a to
f5de5aa
Compare
When using the agent inspect interface, prevent agent inspection from creating ports by removing "ports" from agent's default_hooks. When using the redfish inspect interface, Redfish inspection creates ports directly through _create_ports() method called from inspect_hardware() method itself, not primarily through hooks.
haseebsyed12
force-pushed
the
skip-port-manipulation-agent-inspect
branch
from
f5de5aa to
36e9bce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redfish inspection - should manipulate ports (create/update ports)
Agent inspection - should NOT manipulate ports (disable the ports hook)
Before:
[inspector]
default_hooks = ramdisk-error,validate-interfaces,ports,architecture
[redfish]
default_inspection_hooks = validate-interfaces,ports,architecture
After:
[inspector]
default_hooks = ramdisk-error,validate-interfaces,architecture
[redfish]
default_inspection_hooks = validate-interfaces,ports,architecture