Skip to content

Commit

Permalink
Fix JS error due to missing element
Browse files Browse the repository at this point in the history
The conditions to show the explanation for m1 support are inconsistent.
The one that triggers the explanation uses version<=? and
the one that creates the explanation uses version<?.
Therefore, when the version is exactly version-before-m1-support,
it attempts to show the explanation that doesn't exist.

This PR makes the adjustment to make the conditions consistent.
Based on the name `version-before-m1-support`,
version<? seems to be the right one to use.

Fixes #336
  • Loading branch information
sorawee committed Nov 25, 2024
1 parent ae66639 commit feda7fb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion download/download-pages.rkt
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ var property = null;
}
null)

@(if (version<=? version-before-m1-support version)
@(if (version<? version-before-m1-support version)
@list{
@; showWhen('m1_mac_explain', platform === 'x86_64-macosx');
showWhen('intel_mac_explain', platform === 'aarch64-macosx');
Expand Down

0 comments on commit feda7fb

Please sign in to comment.