Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Resyntax fixes #477

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #477

wants to merge 12 commits into from

Conversation

resyntax-ci[bot]
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Jan 22, 2025

Resyntax fixed 20 issues in 6 files.

  • Fixed 6 occurrences of let-to-define
  • Fixed 2 occurrences of unless-expression-in-for-loop-to-unless-keyword
  • Fixed 2 occurrences of hash-map-to-hash-keys
  • Fixed 2 occurrences of when-expression-in-for-loop-to-when-keyword
  • Fixed 1 occurrence of single-clause-match-to-match-define
  • Fixed 1 occurrence of if-let-to-cond
  • Fixed 1 occurrence of define-let-to-double-define
  • Fixed 1 occurrence of inline-unnecessary-define
  • Fixed 1 occurrence of or-hash-ref-set!-to-hash-ref!
  • Fixed 1 occurrence of inline-unnecessary-begin
  • Fixed 1 occurrence of always-throwing-if-to-when
  • Fixed 1 occurrence of map-to-for

resyntax-ci bot added 12 commits January 22, 2025 00:15
This `map` operation can be replaced with a `for/list` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `let` expression can be pulled up into a `define` expression.
Use the `#:unless` keyword instead of `unless` to reduce loop body indentation.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
This variable is returned immediately and can be inlined.
This `hash-map` expression is equivalent to the `hash-keys` function.
This `begin` form can be flattened into the surrounding definition context.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This expression can be replaced with a simpler, equivalent `hash-ref!` expression.
This `match` expression can be simplified using `match-define`.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants