Skip to content

Automated Resyntax fixes #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #496

wants to merge 10 commits into from

Conversation

resyntax-ci[bot]
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Apr 9, 2025

Resyntax fixed 20 issues in 8 files.

  • Fixed 4 occurrences of if-begin-to-cond
  • Fixed 4 occurrences of map-to-for
  • Fixed 2 occurrences of if-let-to-cond
  • Fixed 2 occurrences of quasiquote-to-list
  • Fixed 2 occurrences of or-hash-ref-set!-to-hash-ref!
  • Fixed 2 occurrences of let-to-define
  • Fixed 1 occurrence of ormap-to-for/or
  • Fixed 1 occurrence of when-expression-in-for-loop-to-when-keyword
  • Fixed 1 occurrence of string-append-and-string-join-to-string-join
  • Fixed 1 occurrence of always-throwing-if-to-when

resyntax-ci bot added 10 commits April 9, 2025 00:15
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This `map` operation can be replaced with a `for/list` loop.
This quasiquotation is equialent to a simple `list` call.
Using `cond` instead of `if` here makes `begin` unnecessary
This expression can be replaced with a simpler, equivalent `hash-ref!` expression.
This `ormap` operation can be replaced with a `for/or` loop.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This use of `string-append` can be removed by using `string-join`'s keyword arguments.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants