Automated Resyntax fixes #1450
Open
Automated Resyntax fixes #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This `match` expression can be simplified using `match-define`.
This `map` operation can be replaced with a `for/list` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This variable is returned immediately and can be inlined.
This `if` expression can be refactored to an equivalent expression using `and`.
The `else`-`if` branch of this `cond` expression can be collapsed into the `cond` expression.
This `let` expression can be pulled up into a `define` expression.
This expression is equivalent to calling the `negative?` predicate.
samth
reviewed
May 9, 2025
| ([dom (in-list dom*)] | ||
| #:when (pair? dom)) | ||
| (cons (cdr dom) acc))) | ||
| (define check* (protect-loop rst dom+)) |
samth
reviewed
May 9, 2025
| [range-stx (if range #`(values #,@(map f range)) #'any)]) | ||
| #'(arg-stx ... rest-stx ... . -> . range-stx))])) | ||
| (match-define (arr-combinator (arr-seq args rest range)) v) | ||
| (with-syntax ([(arg-stx ...) (map f args)] |
There was a problem hiding this comment.
Should resyntax use define/with-syntax?
There was a problem hiding this comment.
I've considered it. The opportunity doesn't seem to come up much though.
samth
reviewed
May 9, 2025
| (map f* vals) | ||
| (and call-cc (map f* call-cc)))])) | ||
| (match-define (pt-seq vals call-cc) seq) | ||
| (define (f* a) |
There was a problem hiding this comment.
I really want a way to turn this formatting decision off.
There was a problem hiding this comment.
This function in particular hardly seems worth defining at all.
samth
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 50 issues in 18 files.
single-clause-match-to-match-definelet-to-definedefine-let-to-double-defineinline-unnecessary-definezero-comparison-to-negative?map-to-forcond-else-if-to-condif-else-false-to-and