Skip to content

test(Select): keyboard navigation paths (#1817)#2092

Merged
kodiakhq[bot] merged 3 commits into
mainfrom
test/issue-1817-select-keyboard-paths
Jun 24, 2026
Merged

test(Select): keyboard navigation paths (#1817)#2092
kodiakhq[bot] merged 3 commits into
mainfrom
test/issue-1817-select-keyboard-paths

Conversation

@kotAPI

@kotAPI kotAPI commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

arrow/home/end/escape keyboard navigation regression tests

Test plan

  • Related unit tests pass locally

Related to #1817

Summary by CodeRabbit

  • Tests
    • Added keyboard interaction coverage for the Select component.
    • Verified arrow key navigation, Home/End selection, and Escape behavior.
    • Confirmed the menu closes and focus returns to the trigger after dismissing the Select.

@changeset-bot

changeset-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 97767cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kotAPI

kotAPI commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Code review

LGTM. Matches project patterns for portal Theme refs, Floating UI prop merge, controlled-switch/lazy-mount/RTL tests, or focused bug fixes. No changes requested.

@GoldGroove06 GoldGroove06 added the automerge A tag that tells kodiak bot to automerge PRs for us when tests and approval conditions are met label Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ecd623f7-2cba-476c-8294-7a8e2774c129

📥 Commits

Reviewing files that changed from the base of the PR and between 45aefb5 and 724b955.

📒 Files selected for processing (1)
  • src/components/ui/Select/tests/Select.keyboard.test.tsx

📝 Walkthrough

Walkthrough

Adds a new test file Select.keyboard.test.tsx that defines a mockMatchMedia helper and a describe('Select keyboard paths') suite. The suite renders a themed Select with three items and verifies ArrowDown, End, Home, and Escape key interactions, including data-active attribute changes and focus restoration to the trigger.

Changes

Select Keyboard Tests

Layer / File(s) Summary
Select keyboard navigation tests
src/components/ui/Select/tests/Select.keyboard.test.tsx
New test suite with a matchMedia mock that renders a themed Select and asserts ArrowDown moves active option, End selects last, Home selects first, and Escape closes the menu and returns focus to the trigger.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 Hop hop, the keys go click,
ArrowDown and End do their trick,
Home brings focus back in place,
Escape shuts the menu with grace —
The rabbit typed tests, oh so quick! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding Select keyboard navigation tests for the referenced issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/issue-1817-select-keyboard-paths

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: one or more packages not found in the registry.


Comment @coderabbitai help to get the list of available commands.

@kodiakhq kodiakhq Bot merged commit e2e163f into main Jun 24, 2026
7 of 8 checks passed
@kodiakhq kodiakhq Bot deleted the test/issue-1817-select-keyboard-paths branch June 24, 2026 16:37
@github-actions

Copy link
Copy Markdown
Contributor

Coverage

This report compares the PR with the base branch. "Δ" shows how the PR affects each metric.

Metric PR Δ
Statements 78.31% -0.01%
Branches 61.14% -0.03%
Functions 63.6% -0.10%
Lines 79.9% -0.01%

Coverage decreased for at least one metric. Please add or update tests to improve coverage.

Run npm run coverage:ci locally for detailed reports and target untested areas to raise these numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge A tag that tells kodiak bot to automerge PRs for us when tests and approval conditions are met

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants