embed maps #7
embed maps #7
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces interactive React map components with embedded iframes for documentation examples. The change transitions from using local MDX components to displaying maps via a hosted Replit development environment.
- Removes all map component imports from the MDX file
- Replaces 8 different map example components with iframe embeds pointing to a Replit instance
- Each iframe includes query parameters to specify the map type being demonstrated
|
|
||
| Radar Maps is a cost-effective alternative to Google Maps Platform and Mapbox. | ||
|
|
||
| For example, here's a Radar Map displaying a marker for Radar HQ: | ||
|
|
||
| <Map /> | ||
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev/" width="100%" height="500" frameBorder="0" allowFullScreen /> |
There was a problem hiding this comment.
The iframe src uses a development/temporary Replit URL that contains random identifiers. This URL will likely become invalid when the development session ends, breaking the embedded maps in production documentation.
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev/" width="100%" height="500" frameBorder="0" allowFullScreen /> | |
| <iframe src="https://radar.com/demo/maps" width="100%" height="500" frameBorder="0" allowFullScreen /> |
Copilot uses AI. Check for mistakes.
| @@ -359,7 +351,7 @@ Use the `map.fitToMarkers()` function to center and zoom the map to encompass al | |||
|
|
|||
| In the example below, clicking the map will place a new marker, and refit the map so all markers are visible. Clicking a marker will remove it. | |||
|
|
|||
| <FitBoundsMap /> | |||
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=fitBounds" width="100%" height="500" frameBorder="0" allowFullScreen /> | |||
There was a problem hiding this comment.
The frameBorder attribute is deprecated in HTML5. Use CSS border styling instead: style="border: none;"
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=fitBounds" width="100%" height="500" frameBorder="0" allowFullScreen /> | |
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=fitBounds" width="100%" height="500" style="border: none;" allowFullScreen /> |
Copilot uses AI. Check for mistakes.
| @@ -461,7 +453,7 @@ export default RadarMap; | |||
|
|
|||
| Add a `Marker` with a custom image to the map by specifying the image URL. | |||
|
|
|||
| <CustomImageMarkerMap /> | |||
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=customImageMarker" width="100%" height="500" frameBorder="0" allowFullScreen /> | |||
There was a problem hiding this comment.
Consider adding sandbox and referrerpolicy attributes to the iframe for better security when embedding external content.
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=customImageMarker" width="100%" height="500" frameBorder="0" allowFullScreen /> | |
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=customImageMarker" width="100%" height="500" frameBorder="0" allowFullScreen sandbox="allow-scripts allow-same-origin" referrerpolicy="no-referrer" /> |
Copilot uses AI. Check for mistakes.
No description provided.