improve plot_channel_maps by adding parameters for the usage of colorbar #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add three parameters for plot_channel_maps so that one can plot and adjust a color bar for the channel maps.
Jiangxuejian
changed the title
keflavich
requested changes
Oct 8, 2020
Contributor
keflavich
left a comment
keflavich
left a comment
There was a problem hiding this comment.
Looks like a helpful addition.
If you don't specify vmin/vmax, this colorbar will only be appropriate for the final panel, right? We perhaps should force that vmin/vmax or norm are specified if the colorbar is included.
Co-authored-by: Adam Ginsburg <[email protected]>
Co-authored-by: Adam Ginsburg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add three parameters for plot_channel_maps so that one can plot and adjust a color bar for the channel maps.