Skip to content

Conversation

@keflavich
Copy link
Contributor

This is associated with astropy/reproject#351 and enables cube mosaicing with memory mapping. It might also work with astropy/reproject#388, but that's unclear.

@keflavich keflavich marked this pull request as draft December 3, 2023 00:50
@keflavich keflavich force-pushed the cubewcs_mosaic_and_dask_reproject branch from 5bc5a6c to cca08dc Compare December 8, 2023 01:20
@keflavich keflavich force-pushed the cubewcs_mosaic_and_dask_reproject branch from 5290d36 to bbb71a1 Compare February 9, 2024 19:00
@keflavich keflavich force-pushed the cubewcs_mosaic_and_dask_reproject branch 2 times, most recently from 26a1aba to c636655 Compare October 18, 2024 20:19
@keflavich keflavich force-pushed the cubewcs_mosaic_and_dask_reproject branch from 8320826 to 14fa698 Compare January 22, 2025 16:54
@keflavich keflavich marked this pull request as ready for review January 26, 2025 17:37
@keflavich
Copy link
Contributor Author

I've been commenting on #868 with my work on this PR.

This PR now depends on astropy/reproject#474

@keflavich
Copy link
Contributor Author

interesting, the tests are failing on CI with an 'unterminated string error' that is simply incorrect; the code runs fine, so it is syntactically correct. I'll get rid of it, though.

@keflavich
Copy link
Contributor Author

Tests now pass locally. CI won't pass until we can hook up to astropy/reproject#474

@keflavich keflavich force-pushed the cubewcs_mosaic_and_dask_reproject branch from 8ba6b27 to bcffa26 Compare July 18, 2025 15:30
@keflavich
Copy link
Contributor Author

I'm actively running this with reproject/0ce57c37d6bf64e6f0febdfddf36a556abba04c5, i.e., the current main. It works. spectral-cube/main does not have a comparable capability.

@keflavich
Copy link
Contributor Author

I don't know why setup.cfg is showing up in the diff... maybe I added it back where I was supposed to remove it during rebase? I can never tell what's happening when it just says "conflict" and there is no conflict in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants