-
Notifications
You must be signed in to change notification settings - Fork 65
Enable attestations for PyPI publish action #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I see this on your publish log. A new Trusted Publisher for the currently running publishing workflow can be created by accessing the following link(s) while logged-in as an owner of the package(s): Trusted Publishers allows publishing packages to PyPI from automated environments like GitHub Actions without needing to use username/password combinations or API tokens to authenticate with PyPI. Read more: https://docs.pypi.org/trusted-publishers attestations input ignoredThe workflow was run with the 'attestations: true' input, but an explicit password was also set, disabling Trusted Publishing. As a result, the attestations input is ignored. |
|
Not sure what's up with the RTD failure here. Maybe transient? Also not sure how you can test this until you make the next release. |
|
yeah, I already added the attestation - that link has no effect any more |
|
The rtf failure must be transient? Nothing changed on that end and the last successful build was 45 min ago. |
|
Oh I see the problem. @keflavich you need to rebase to update the rtd yaml file: https://github.com/radio-astro-tools/spectral-cube/blob/main/.readthedocs.yml |
fddafa4 to
b032e9a
Compare
|
apparently my local branch was in a weird state that caused this. |
|
Huh, is the Windows failure expected?
|


This is recommended by .... the warnings on pypi publish workflows
Warning: The workflow was run with the 'attestations: true' input, but an explicit password was also set, disabling Trusted Publishing. As a result, the attestations input is ignored.
Warning: Trusted Publishers allows publishing packages to PyPI from automated environments like GitHub Actions without needing to use username/password combinations or API tokens to authenticate with PyPI. Read more: https://docs.pypi.org/trusted-publishers
Warning: A new Trusted Publisher for the currently running publishing workflow can be created by accessing the following link(s) while logged-in as an owner of the package(s):