Skip to content

Conversation

@thekingofcity
Copy link
Member

This should fix #221

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements sharing functionality for RMP works, including API support, UI components, and necessary translations, and adds a utility for random save names.

  • Introduces getRandomCityName to generate random save names.
  • Extends API_ENDPOINT and APISaveInfo to support share operations.
  • Adds translation entries for sharing UI in multiple locales.
  • Implements ShareModal component for creating/deleting share links.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/util/random-save-name.ts New utility with a list of city names for saves
src/util/constants.ts Added /share endpoint and share fields to types
src/i18n/translations/zh-Hant.json Added share-related translation keys
src/i18n/translations/zh-Hans.json Added share-related translation keys
src/i18n/translations/ko.json Added share-related translation keys
src/i18n/translations/ja.json Added share-related translation keys
src/components/menu/account-view/share-modal.tsx New modal component for sharing works
Comments suppressed due to low confidence (1)

src/components/menu/account-view/share-modal.tsx:151

  • The URL appends .org to the share token—verify if this suffix is intended or if it should be omitted.
                        value={`${window.origin}?app=rmp&searchParams=${share.s}.org`}

@thekingofcity thekingofcity merged commit 387a880 into main Jun 4, 2025
1 check passed
@thekingofcity thekingofcity deleted the #221-Share-rmp-work branch June 4, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share rmp work

2 participants