-
Notifications
You must be signed in to change notification settings - Fork 14
#221 Share rmp work #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#221 Share rmp work #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements sharing functionality for RMP works, including API support, UI components, and necessary translations, and adds a utility for random save names.
- Introduces
getRandomCityNameto generate random save names. - Extends
API_ENDPOINTandAPISaveInfoto support share operations. - Adds translation entries for sharing UI in multiple locales.
- Implements
ShareModalcomponent for creating/deleting share links.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/random-save-name.ts | New utility with a list of city names for saves |
| src/util/constants.ts | Added /share endpoint and share fields to types |
| src/i18n/translations/zh-Hant.json | Added share-related translation keys |
| src/i18n/translations/zh-Hans.json | Added share-related translation keys |
| src/i18n/translations/ko.json | Added share-related translation keys |
| src/i18n/translations/ja.json | Added share-related translation keys |
| src/components/menu/account-view/share-modal.tsx | New modal component for sharing works |
Comments suppressed due to low confidence (1)
src/components/menu/account-view/share-modal.tsx:151
- The URL appends
.orgto the share token—verify if this suffix is intended or if it should be omitted.
value={`${window.origin}?app=rmp&searchParams=${share.s}.org`}
This should fix #221