Postal address fields

app/controllers/users_controller.rb

@@ -97,7 +97,7 @@ def user_params
       :github_handle, :twitter_handle, :irc_handle,
       :name, :email, :homepage, :location, :bio,
       :tech_expertise_list, :tech_interest_list,
-      :tshirt_size, :tshirt_cut, :postal_address, :timezone,
+      :tshirt_size, :tshirt_cut, :timezone,
       :country,
       :hide_email,
       :is_company, :company_name, :company_info,
@@ -107,7 +107,8 @@ def user_params
       :application_learning_history, :application_skills, :application_code_samples,
       :application_location, :application_minimum_money, :application_money, :application_goals, :application_code_background,
       interested_in: [],
-      roles_attributes: [:id, :name, :team_id, :_destroy]
+      roles_attributes: [:id, :name, :team_id, :_destroy],
+      postal_address_attributes: [:id, :address_line_1, :address_line_2, :city, :state_or_province, :postal_code, :country, :_destroy]
     )
   end
 end

app/models/postal_address.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+class PostalAddress < ApplicationRecord
+  belongs_to :user
+  validates_presence_of :address_line_1, :city, :postal_code, :country
+
+  def formatted
+    "#{capitalize(address_line_1)} #{capitalize(address_line_2)} #{capitalize(city)}, #{state_or_province} #{postal_code} #{country}"
+  end
+
+  private
+
+  def capitalize(string)
+    string.split.map(&:capitalize).join(' ')
+  end
+end

app/models/user.rb

@@ -65,6 +65,7 @@ def student
   has_many :applications, through: :teams
   has_many :todos, dependent: :destroy
   has_many :comments, dependent: :destroy
+  has_one :postal_address, dependent: :destroy
 
   validates :github_handle, presence: true, uniqueness: { case_sensitive: false }
   validates :homepage, format: { with: URL_PREFIX_PATTERN }, allow_blank: true
@@ -73,6 +74,11 @@ def student
   validates :name, :email, :country, :location, presence: true, unless: :github_import
 
   accepts_nested_attributes_for :roles, allow_destroy: true
+  accepts_nested_attributes_for :postal_address, allow_destroy: true, reject_if: :all_blank
+
+  def postal_address_rejectable?(attr)
+    attr['address_line_1'].blank? || attr['city'].blank? || attr['postal_code'].blank? || attr['country'].blank?
+  end
 
   before_save :normalize_location
   after_create :complete_from_github

app/views/users/edit.html.slim

@@ -107,7 +107,17 @@
   p.help-block This information will only be visible to yourself and the organizers.
   = f.input :tshirt_size, as: :select, collection: User::TSHIRT_SIZES.map { |k| [k, k] }, label: 'T-Shirt size', blank: false, required: false, hint: 'For sponsor T-Shirts, in case they send some.'
   = f.input :tshirt_cut, as: :select, collection: User::TSHIRT_CUTS.map { |s| [s, s] }, label: 'T-Shirt cut', include_blank: true
-  = f.input :postal_address, hint: "Please give your postal address, including your full name, so we can send things we've received from our sponsors for you :)"
+  h4 Shipping Address
+  - if @user.postal_address
+     = link_to "Remove Address", user_path(@user, user: { postal_address_attributes: { id: @user.postal_address.id, "_destroy" => true }}), method: :put, data: { confirm: 'Are you sure?' }
+  = f.simple_fields_for :postal_address_attributes, @user.postal_address do |pa|
+    = pa.input :address_line_1, required: false
+    = pa.input :address_line_2, required: false
+    = pa.input :city, required: false
+    = pa.input :state_or_province, required: false
+    = pa.input :postal_code, required: false
+    = pa.input :country, prompt: "Select your country", required: false, include_blank: true
+
 
   - if admin?
     h3.page-header Roles

app/views/users/show.html.slim

@@ -65,9 +65,13 @@ nav.actions
     p = @user.company_info
 
   - if can_see_private_info?
-    - fields = ['tshirt_size', 'tshirt_cut', 'postal_address']
     .well.private-info
       h3 Private info
+      - if @user.postal_address
+        h4 Postal Address
+        p
+        = @user.postal_address.formatted
+      - fields = ['tshirt_size', 'tshirt_cut']
       - fields.each do |field|
         - if @user.send(field).present?
           p

db/migrate/20181107171037_create_postal_addresses.rb

@@ -0,0 +1,15 @@
+class CreatePostalAddresses < ActiveRecord::Migration[5.1]
+  def change
+    create_table :postal_addresses do |t|
+      t.string :address_line_1
+      t.string :address_line_2
+      t.string :city
+      t.string :state_or_province
+      t.string :postal_code
+      t.string :country
+
+      t.references :user, foreign_key: true
+      t.timestamps
+    end
+  end
+end

db/migrate/20181107172409_remove_postal_address_from_users.rb

@@ -0,0 +1,5 @@
+class RemovePostalAddressFromUsers < ActiveRecord::Migration[5.1]
+  def change
+    remove_column :users, :postal_address, :text
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20180714153306) do
+ActiveRecord::Schema.define(version: 20181107172409) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -173,6 +173,19 @@
     t.index ["user_id"], name: "index_notes_on_user_id"
   end
 
+  create_table "postal_addresses", force: :cascade do |t|
+    t.string "address_line_1"
+    t.string "address_line_2"
+    t.string "city"
+    t.string "state_or_province"
+    t.string "postal_code"
+    t.string "country"
+    t.bigint "user_id"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["user_id"], name: "index_postal_addresses_on_user_id"
+  end
+
   create_table "projects", id: :serial, force: :cascade do |t|
     t.string "name", limit: 255
     t.datetime "created_at"
@@ -296,7 +309,6 @@
     t.string "twitter_handle", limit: 255
     t.string "irc_handle", limit: 255
     t.string "tshirt_size", limit: 255
-    t.text "postal_address"
     t.string "timezone", limit: 255
     t.string "interested_in", limit: 255, default: [], array: true
     t.boolean "hide_email"
@@ -339,5 +351,6 @@
     t.index ["confirmation_token"], name: "index_users_on_confirmation_token", unique: true
   end
 
+  add_foreign_key "postal_addresses", "users"
   add_foreign_key "teams", "projects"
 end

spec/factories/postal_address.rb

@@ -0,0 +1,11 @@
+FactoryBot.define do
+  factory :postal_address do
+    user
+    address_line_1 { FFaker::AddressUS.street_address }
+    address_line_2 { FFaker::AddressUS.secondary_address }
+    city { FFaker::AddressUS.city}
+    state_or_province { FFaker::AddressUS.state}
+    postal_code { FFaker::AddressUS.zip_code}
+    country { FFaker::Address.country }
+  end
+end

spec/features/users/postal_address_spec.rb

@@ -0,0 +1,70 @@
+require 'rails_helper'
+
+RSpec.describe 'Add Postal Address', type: :feature do
+  let(:user) { create(:user) }
+  let(:address) { create(:postal_address) }
+
+  context 'signed in' do
+    before { sign_in user }
+
+    context 'in the user edit page' do
+      before { visit edit_user_path(user) }
+
+      it 'allows creation of postal address if all required address fields are entered' do
+        fill_in 'user[postal_address_attributes][address_line_1]',    with: address.address_line_1
+        fill_in 'user[postal_address_attributes][address_line_2]',    with: address.address_line_2
+        fill_in 'user[postal_address_attributes][city]',              with: address.city
+        fill_in 'user[postal_address_attributes][state_or_province]', with: address.state_or_province
+        fill_in 'user[postal_address_attributes][postal_code]',       with: address.postal_code
+        select address.country, from: 'user[postal_address_attributes][country]'
+        click_on 'Save'
+
+        expect(current_path).to eq user_path(user)
+
+        expect(page).to have_content address.address_line_1
+        expect(page).to have_content address.address_line_2
+        expect(page).to have_content address.city
+        expect(page).to have_content address.state_or_province
+        expect(page).to have_content address.postal_code
+        expect(page).to have_content user.postal_address.country
+      end
+
+      it 'does not allow a postal address to be added if required fields are missing' do
+        expect(user.postal_address).to be_nil
+        fill_in 'user[postal_address_attributes][address_line_1]',    with: address.address_line_1
+        fill_in 'user[postal_address_attributes][postal_code]',       with: address.postal_code
+        click_on 'Save'
+
+        expect(page).to have_content "Postal address city can't be blank"
+        expect(page).to have_content "Postal address country can't be blank"
+      end
+
+      it 'autofills saved postal address info on edit form if it exists' do
+        user.update(postal_address: create(:postal_address))
+        visit edit_user_path(user)
+
+        expect(page).to have_selector("input[value='#{user.postal_address.address_line_1}']")
+        expect(page).to have_selector("input[value='#{user.postal_address.city}']")
+        expect(page).to have_selector("input[value='#{user.postal_address.state_or_province}']")
+        expect(page).to have_selector("input[value='#{user.postal_address.postal_code}']")
+      end
+
+      it 'lets you delete an existing postal address' do
+        user.update(postal_address: address)
+        visit edit_user_path(user)
+
+        accept_alert do
+          click_on 'Remove Address'
+        end
+
+        expect(current_path).to eq user_path(user)
+
+        expect(page).to_not have_content address.address_line_1
+        expect(page).to_not have_content address.address_line_2
+        expect(page).to_not have_content address.city
+        expect(page).to_not have_content address.state_or_province
+        expect(page).to_not have_content address.postal_code
+      end
+    end
+  end
+end

spec/models/postal_address_spec.rb

@@ -0,0 +1,14 @@
+require 'rails_helper'
+
+RSpec.describe PostalAddress, type: :model do
+  describe 'associations' do
+    it { is_expected.to belong_to(:user) }
+  end
+
+  describe 'validations' do
+    it { is_expected.to validate_presence_of(:address_line_1)}
+    it { is_expected.to validate_presence_of(:city)}
+    it { is_expected.to validate_presence_of(:postal_code)}
+    it { is_expected.to validate_presence_of(:country)}
+  end
+end

spec/models/user_spec.rb

@@ -12,6 +12,7 @@
     it { is_expected.to have_many(:applications).through(:teams) }
     it { is_expected.to have_many(:todos).dependent(:destroy) }
     it { is_expected.to have_many(:comments).dependent(:destroy) }
+    it { is_expected.to have_one(:postal_address).dependent(:destroy) }
   end
 
   describe 'validations' do