Skip to content

Handle custom session_class in all rake tasks #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle custom session_class in all rake tasks #179

wants to merge 1 commit into from

Conversation

ghiculescu
Copy link
Member

@ghiculescu ghiculescu commented Mar 10, 2021 •
edited
Loading

  • Updates all rake tasks to use ActionDispatch::Session::ActiveRecordStore.session_class
  • Updates README to note which additional methods are needed if you use a custom session class
  • Adds a test for an untested rake task

Co-authored-by @marvinthepa

@ghiculescu ghiculescu mentioned this pull request Mar 10, 2021
Open
marvinthepa
marvinthepa reviewed Mar 10, 2021
View reviewed changes
@ghiculescu ghiculescu force-pushed the patch-1 branch 2 times, most recently from cc2d660 to c7f1f22 Compare March 10, 2021 19:20
@ghiculescu ghiculescu changed the title Handle custom session_class in trim task Handle custom session_class in all rake tasks Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@marvinthepa marvinthepa marvinthepa left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiculescu @marvinthepa