Fix assert_not_select on body for text or html
#125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -477,7 +477,8 @@ def test_feed_item_encoded_with_html_version | |||
|
|
|||
| def test_body_not_present_in_empty_document | |||
| render_html "<div></div>" | |||
| assert_select "body", 0 | |||
| error = assert_raises(ArgumentError) { assert_select "body", 0 } | |||
There was a problem hiding this comment.
This is a breaking change. Why do we need it?
There was a problem hiding this comment.
Nokogiri adds a <body> (and <html>) when it's not present. In this case, the rendered html would be <html><body><div></div></body></html>.
So asserting a count (or minimum/maximum) on <body> does not make sense. Now that I think about it, we should prolly do the same thing with <html>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
First of all, thank you so much for your work on this gem 🙏
While working on a project, I wrote the following test:
The problem is that, with the current code, the last assertion always passes (even with "bar" in the body).
This PR fixes it.