Prevent double initialization of charts #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #22, where charts were being initialized multiple times on the same DOM element. This caused unexpected behavior, duplicate event listeners, and unnecessary memory usage.
✅ What’s changed
getInstanceByDomto check whether a chart instance already exists on the target DOM element.🧪 Why this works
ECharts recommends using
lib.getInstanceByDom(chartDom)to detect existing instances. If an instance exists, we skip initialization, avoiding the “double init” problem.