feat(search)!: Migrate to new Search UI powered by Meilisearch#240
Merged
feat(search)!: Migrate to new Search UI powered by Meilisearch#240
Conversation
|
This PR is being deployed to Railway 🚅 📚 railway docs: ◻️ REMOVED |
This was referenced Apr 24, 2023
half0wl
commented
Apr 24, 2023
coffee-cup
reviewed
Apr 24, 2023
Contributor
coffee-cup
left a comment
There was a problem hiding this comment.
Overall looks good! I think there should be a follow up PR that fixes the keyboard navigation since that was pretty confusing when I first tried it out.
There also isn't a clear separation between the result items, but that is maybe a Jitachi question?
ndneighbor
reviewed
Apr 24, 2023
ndneighbor
approved these changes
Apr 24, 2023
Contributor
ndneighbor
left a comment
There was a problem hiding this comment.
Nothing else to add except from JR's comments. I have two nits, but mostly they are stylistic concerns that can be waived away if you don't feel that they are important.
coffee-cup
approved these changes
Apr 24, 2023
This was referenced Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the existing tag-based search with site-wide full-text search, powered by Meilisearch Cloud.
useDebouncedSearchhook.Live demo
railway-docs-docs-pr-240.up.railway.app
Related PRs
Screens
Future Improvements
Rollout
production:NEXT_PUBLIC_MEILISEARCH_HOSTNEXT_PUBLIC_MEILISEARCH_READ_API_KEYNEXT_PUBLIC_MEILISEARCH_INDEX_NAME