Rework query store enabled handling #6483
Open
+123
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
setState
enabled
handling up to the store'ssetState
function — previously the override existed at the subscription level which was redundant and lacked full coverageenabled
to ensure the config'senabled
value is always respected when the store is rebuiltparams
or a dynamicenabled
value are provided — previously dynamicenabled
values wouldn't be resolved if no params were providedenabled
values to ensure any mismatched persistedenabled
values get back in syncskipStoreUpdates: 'withCache'
option for manualfetch
callsgetCompleteParams
functionScreen recordings / screenshots
What to test