Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework query store enabled handling #6483

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

christianbaroni
Copy link
Member

What changed (plus any additional context for devs)

  • Moves the setState enabled handling up to the store's setState function — previously the override existed at the subscription level which was redundant and lacked full coverage
  • No longer persisting enabled to ensure the config's enabled value is always respected when the store is rebuilt
  • Now correctly resolving params if either params or a dynamic enabled value are provided — previously dynamic enabled values wouldn't be resolved if no params were provided
  • Adjusts the check for non-dynamic enabled values to ensure any mismatched persisted enabled values get back in sync
  • Adds a skipStoreUpdates: 'withCache' option for manual fetch calls
  • Extracts the partial params handling to a pure getCompleteParams function

Screen recordings / screenshots

What to test

@brunobar79
Copy link
Member

Launch in simulator or device for 5a89309

@jinchung jinchung changed the base branch from develop to @main/ftl March 6, 2025 02:40
@jinchung jinchung changed the base branch from @main/ftl to develop March 6, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants