Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Skia cards, new ftl sheets #6487

Open
wants to merge 19 commits into
base: @christian/ftl-coin-flip
Choose a base branch
from
Open

Add Skia cards, new ftl sheets #6487

wants to merge 19 commits into from
+2,297 −98

Conversation

christianbaroni
Copy link
Member

@christianbaroni christianbaroni commented Mar 6, 2025 •
edited
Loading

What changed (plus any additional context for devs)

  • Creates a reusable SkiaCard component
  • Adds new discover cards under a feature flag
  • Adds a new paginated airdrops query store
  • Adds a new design system component for rendering Skia-based text, which mirrors the existing Text component API
    • Uses a single, shared font manager across all components
    • On iOS it uses Skia’s system font manager and reuses paragraph builders per text alignment
    • On Android it uses a custom typeface provider, which lazy loads font weights as needed (on Android the system font manager doesn’t contain the fonts we need)
  • Fixes excessive fetches in discover search — was previously fetching an external asset for each list item, for no clear reason

Screen recordings / screenshots

What to test

@christianbaroni christianbaroni changed the base branch from develop to @christian/ftl-coin-flip March 6, 2025 23:57
@christianbaroni christianbaroni force-pushed the @christian/ftl-coin-flip branch from 8ff8eea to bd6988a Compare March 7, 2025 00:33
@socket-security Socket Security
Copy link

socket-security bot commented Mar 7, 2025 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@legendapp/[email protected] None 0 169 kB jmeistrich
npm/[email protected] None 0 26.6 kB phamfoo

View full report↗︎

@christianbaroni christianbaroni marked this pull request as ready for review March 10, 2025 05:07
@brunobar79
Copy link
Member

Launch in simulator or device for 7d2b9f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat Awaiting requested review from walmat

@derHowie derHowie Awaiting requested review from derHowie

@maxbbb maxbbb Awaiting requested review from maxbbb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianbaroni @brunobar79