Better dummy for test and better demo example for demonstration and documentation #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d skip - instead of a real module, which currenly passes all tests, hence making it useless as a demo and a testing dummy
subtlepseudonym
suggested changes
May 26, 2020
Updated with explicit link to commit Co-authored-by: Connor <[email protected]>
subtlepseudonym
approved these changes
May 27, 2020
Contributor
subtlepseudonym
left a comment
subtlepseudonym
left a comment
There was a problem hiding this comment.
Looks good to me.
I'm not requesting changes, but just in case my earlier comment was unclear, I believe the commit sha (9daa3c5) to be the better link because the tag link could, but in practice won't, be changed to point to a different commit.
Contributor
Author
|
Just let me know your preference, you are linking outside the repository itself, so I understand if you prefer a more static URL, were worst case is a 404. |
rakyll
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added better example based on a new demo demonstrating pass, fail and skip - instead of the real module "hey", which currently pass all tests, hence making it useless as a demo and testing dummy.
Please be aware that it demontrates skip, which is currently not implemented in master, but is available in some of the PRs like: #17 and #18
This is just a demonstration of how it could be done, it currently scratches my own itch, so a copy of the repository under the control of the gotest test might be preferable. Until then please feel free to use my repository and example.