Skip to content

Conversation

@jonasbn
Copy link
Contributor

@jonasbn jonasbn commented Jan 24, 2022

Removed prefixed dollar-sign for easier copy and pasting from documentation and removed a few warnings from Markdownlint.

Copy link
Contributor

@subtlepseudonym subtlepseudonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I'd suggest reformatting the commit message on merge. The existing one is longer than the usual 50 characters.

@jonasbn
Copy link
Contributor Author

jonasbn commented Feb 14, 2022

I adjusted the commit message, I attempted to squash the commit, but my commit-squash-foo is not good

@subtlepseudonym
Copy link
Contributor

No worries! Limiting the length of the commit message is mostly aesthetic at this point.

For fixing the git history / commit message, we could wait for rakyll, who can squash-merge and update the commit message before it's added to the history on master. Or, you can fix it locally with some git-foo:

  • git checkout copy-pasta
    • just to make sure we're on the right branch
  • git reset --hard dd5fefeed69ac0682f70acf8788916dd4f78ab68
    • this resets your local branch the original commit, throwing away the later changes
  • git commit --amend --message "the shorter, updated commit message"
    • this updates the commit message (and the commit hash, so branches copy-pasta and origin/copy-pasta will be out of sync)
  • git push --force
    • this forcibly overwrites the branch origin/copy-pasta with your local changes on copy-pasta, which you'll see reflected on this pull-request

Let me know if I'm explaining stuff you already know. The changes still look good so any git shenanigans are totally just nitpicking on my part.

from documentation and removed a few warnings from Markdownlint
@jonasbn
Copy link
Contributor Author

jonasbn commented Feb 15, 2022

Thanks for the assistance @subtlepseudonym

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants