Skip to content

Commit

Permalink
Remove invalid comments in hack/lib/version.sh
Browse files Browse the repository at this point in the history
Signed-off-by: HaoJie Liu <[email protected]>
  • Loading branch information
HecarimV committed Jul 6, 2022
1 parent d2cea94 commit 4990214
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions hack/lib/version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,14 @@ kube::version::load_version_vars() {
# Prints the value that needs to be passed to the -ldflags parameter of go build
# in order to set the Kubernetes based on the git tree status.
# IMPORTANT: if you update any of these, also update the lists in
# pkg/version/def.bzl and hack/print-workspace-status.sh.
# hack/print-workspace-status.sh.
kube::version::ldflags() {
kube::version::get_version_vars

local -a ldflags
function add_ldflag() {
local key=${1}
local val=${2}
# If you update these, also update the list component-base/version/def.bzl.
ldflags+=(
"-X '${KUBE_GO_PACKAGE}/vendor/k8s.io/client-go/pkg/version.${key}=${val}'"
"-X '${KUBE_GO_PACKAGE}/vendor/k8s.io/component-base/version.${key}=${val}'"
Expand Down
1 change: 0 additions & 1 deletion hack/print-workspace-status.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ kube::version::get_version_vars
# Stamped rules will be retriggered by changes to stable-status.txt, but not by
# changes to volatile-status.txt.
# IMPORTANT: the camelCase vars should match the lists in hack/lib/version.sh
# and staging/src/k8s.io/kubectl/pkg/version/def.bzl.
cat <<EOF
STABLE_BUILD_GIT_COMMIT ${KUBE_GIT_COMMIT-}
STABLE_BUILD_SCM_STATUS ${KUBE_GIT_TREE_STATE-}
Expand Down

0 comments on commit 4990214

Please sign in to comment.