fix: don't try to clean up pvs on nodes that are gone #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusramberg
changed the title
marcusramberg
force-pushed
the
marcus/ephemeral_fix
branch
4 times, most recently
from
69c6989 to
1e1388b
Compare
Contributor
Author
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
derekbit
reviewed
Jul 30, 2025
provisioner.go
Outdated
Comment on lines
487
to
493
| if _, err := p.kubeClient.CoreV1().Nodes().Get(context.TODO(), node, metav1.GetOptions{}); err != nil { | ||
| logrus.Infof("Node %v does not exist, skipping cleanup of volume %v", node, pv.Name) | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
@marcusramberg WDYT?
Suggested change
| if _, err := p.kubeClient.CoreV1().Nodes().Get(context.TODO(), node, metav1.GetOptions{}); err != nil { | |
| logrus.Infof("Node %v does not exist, skipping cleanup of volume %v", node, pv.Name) | |
| return nil | |
| } | |
| if _, err := p.kubeClient.CoreV1().Nodes().Get(context.TODO(), node, metav1.GetOptions{}); err != nil && apierrors.IsNotFound(err) { | |
| logrus.Infof("Node %v does not exist, skipping cleanup of volume %v", node, pv.Name) | |
| return nil | |
| } |
Contributor
Author
There was a problem hiding this comment.
That seems reasonable to me, I'll update the PR. It's imported in there as k8serror tho.
marcusramberg
force-pushed
the
marcus/ephemeral_fix
branch
from
1e1388b to
bdf05c2
Compare
derekbit
approved these changes
Jul 31, 2025
Member
derekbit
left a comment
derekbit
left a comment
There was a problem hiding this comment.
LGTM @marcusramberg. Thanks for your contribution. The improvement will be in v0.0.33 that is scheduled in Oct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running local-provisioner to provide local storage for CI runners where nodes come and go pretty frequently.
We observe that the provisioner is trying run clean up on nodes that are already gone, which causes helper pods
to be stuck in pending state as they cannot be scheduled.
This PR adds a check to see if the node still exists before trying to clean up the node.