Add workflow to check for broken urls #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
brokenlinks
branch
2 times, most recently
from
2d70d2f to
3afd578
Compare
Signed-off-by: Alexandr Demicev <[email protected]>
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
force-pushed
the
brokenlinks
branch
from
3afd578 to
cfdf079
Compare
alexander-demicev
changed the title
alexander-demicev
changed the title
alexander-demicev
moved this from Proposals In Progress (3 max)
to PR to be reviewed
in CAPI / Turtles
anmazzotti
approved these changes
Apr 30, 2025
furkatgofurov7
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
This is great, but we could also introduce GHA as CI requirement to check links in PRs directly to avoid such issues in future if someone forgets to run local Makefile target for example: https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-md-link-check.yaml from CAPI could be good example
|
It is also relevant in a nightly CI, as we may not always notice changes in documentation, if no PRs were open. |
|
I will make it run on push to main in a follow-up pr |
github-project-automation
bot
moved this from PR to be reviewed
to Done
in CAPI / Turtles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple script to verify that all URLs are valid and fixes all currently broken urls