validate the new project state for consistency, ignore old state [backport 2.12] #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Issue rancher/rancher#51641. This PR is backported from #1118.
The associated Rancher PR is rancher/rancher#52295
Problem
The webhook checked new quotas against old used limit information.
This ignored the possibility that the users may supply bogus used-limit data, for example on project creation.
And further ignored that parts of the system make changes to used-limits.
With bogus used-limit in the project setting this back to good information fails because of the validation failure triggered by the use of the old bad data.
Solution
The webhook now checks the entire new project state, quotas and used-limit for consistency.
CheckList