Use BFGS as default in optimization for function space operators - #416
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 42 42
Lines 6807 6807
=======================================
Hits 6337 6337
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #415 (I also noticed this already some time ago, but never updated the default here),
BFGSusually performs better thanLBFGSfor us at least for the smaller to medium size problems. In the tests it usually converges faster thanLBFGSboth in terms of iteration count and function evaluations, it runs also faster, and usually often even converges to a slightly smaller minimum. The latter even allows us to use slightly tighter tolerances in the tests.I did not change the default
linesearchalgorithm because forBFGSthe difference between them is not as strong as forLBFGSand it would require us to put LineSearches.jl into the extension (we could do that because it would automatically be loaded since Optim.jl loads it, but IMO it would not be so nice).Since this feature is marked as experimental
SummationByPartsOperators.jl/src/function_space_operators.jl
Lines 61 to 62 in ede5990
I think it is fine to change the default.
Closes #415.