Added plugin version fallback for checkstyle on JDK 1.6 - added old f…

…indbugs version suppressions.
raphw · Nov 11, 2015 · 27303db · 27303db
1 parent e821024
commit 27303db
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/byte-buddy-dep/src/main/java/net/bytebuddy/description/type/TypeList.java b/byte-buddy-dep/src/main/java/net/bytebuddy/description/type/TypeList.java
@@ -19,7 +19,7 @@ public interface TypeList extends FilterableList<TypeDescription, TypeList> {
     /**
      * Represents that a type list does not contain any values for ASM interoperability which is represented by {@code null}.
      */
-    @SuppressFBWarnings(value = "MS_MUTABLE_ARRAY", justification = "Value is null")
+    @SuppressFBWarnings(value = {"MS_MUTABLE_ARRAY", "MS_OOI_PKGPROTECT"}, justification = "value is null and should be available to extensions")
     String[] NO_INTERFACES = null;
 
     /**

diff --git a/byte-buddy-dep/src/main/java/net/bytebuddy/implementation/auxiliary/AuxiliaryType.java b/byte-buddy-dep/src/main/java/net/bytebuddy/implementation/auxiliary/AuxiliaryType.java
@@ -21,7 +21,8 @@ public interface AuxiliaryType {
     /**
      * The default type access of an auxiliary type. <b>This array must not be mutated</b>.
      */
-    @SuppressFBWarnings(value = "MS_MUTABLE_ARRAY", justification = "Favor simplicity with current API in overall immutable library layout")
+    @SuppressFBWarnings(value = {"MS_MUTABLE_ARRAY", "MS_OOI_PKGPROTECT"},
+            justification = "Favor simplicity with current API in overall immutable library layout - value should be accessible to extensions")
     ModifierContributor.ForType[] DEFAULT_TYPE_MODIFIER = {SyntheticState.SYNTHETIC};
 
     /**

diff --git a/pom.xml b/pom.xml
@@ -75,8 +75,7 @@
         <!-- Versions 2.6 and 2.7 fail on Travis. -->
         <version.plugin.cobertura>2.5.2</version.plugin.cobertura>
         <version.plugin.coveralls>4.0.0</version.plugin.coveralls>
-        <!-- Subsequent versions of checkstyle require Java 7. -->
-        <version.plugin.checkstyle>2.15</version.plugin.checkstyle>
+        <version.plugin.checkstyle>2.17</version.plugin.checkstyle>
         <version.plugin.findbugs>3.0.1</version.plugin.findbugs>
         <version.annotations.findbugs>3.0.1</version.annotations.findbugs>
         <version.plugin.jitwatch>1.0.1</version.plugin.jitwatch>
@@ -309,6 +308,7 @@
             <properties>
                 <version.plugin.findbugs>2.5.5</version.plugin.findbugs>
                 <version.annotations.findbugs>2.0.3</version.annotations.findbugs>
+                <version.plugin.checkstyle>2.15</version.plugin.checkstyle>
             </properties>
         </profile>
         <!-- Creates additional artifacts that are required for deployment. -->