Merged
Conversation
To simplify installation and reduce footprint, Ray is no longer required for Community Edition tests. What Changed Removed all Ray imports from tests_ce/conftest.py. Eliminated the unused ray_session fixture. Updated all functional test descriptors to use mpPlatform="multiprocessing" instead of "ray". Context Ray is now optional, installable via: pip install "datamimic-ce[ray]" Core code imports Ray lazily only when mpPlatform="ray". Tests no longer require Ray and run clean on default installs. Implication If you rely on Ray for distributed runs, ensure it’s installed manually. Default pip install datamimic-ce uses standard multiprocessing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify installation and reduce footprint, Ray is no longer required for Community Edition tests.
What Changed
Removed all Ray imports from tests_ce/conftest.py.
Eliminated the unused ray_session fixture.
Updated all functional test descriptors to use mpPlatform="multiprocessing" instead of "ray".
Context
Ray is now optional, installable via:
pip install "datamimic-ce[ray]"
Core code imports Ray lazily only when mpPlatform="ray".
Tests no longer require Ray and run clean on default installs.
Implication
If you rely on Ray for distributed runs, ensure it’s installed manually.
Default pip install datamimic-ce uses standard multiprocessing.