Support cudf-polars str.reverse
#19117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
feature request
github-actions
bot
added
Python
mhaseeb123
approved these changes
Jun 7, 2025
davidwendt
reviewed
Jun 7, 2025
mroeschke
approved these changes
Jun 17, 2025
| @@ -409,6 +410,9 @@ def do_evaluate( | |||
| return Column( | |||
| plc.strings.replace.replace_multiple(column.obj, target.obj, repl.obj) | |||
| ) | |||
| elif self.name is StringFunction.Name.Reverse: | |||
| (column,) = columns | |||
| return Column(plc.strings.reverse.reverse(column.obj)) | |||
There was a problem hiding this comment.
Just FYI for future PRs, when contructing Column could you add Column(..., dtype=self.dtype)
Matt711
approved these changes
Jun 24, 2025
Co-authored-by: Matthew Murray <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19025.
needs: pylibcudf tests, docs