Skip to content

Remove pytest pin #19127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: branch-25.08
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
c1adada
Remove pytest pin
vyasr Jun 10, 2025
da7ef6b
Suppress undesired warning
vyasr Jun 10, 2025
0716c9e
Fix warning
vyasr Jun 11, 2025
fe21380
tests(cudf-polars): ignore UserWarning about port fallback
gforsyth Jun 11, 2025
6d97235
tests(custreamz): ignore `module-not-measured` warnings from pytest-cov
gforsyth Jun 11, 2025
860b7ed
Merge branch 'branch-25.08' into chore/remove_pytest_pin
gforsyth Jun 11, 2025
62be925
chore: additional warnings to skip
gforsyth Jun 11, 2025
63ff5c4
chore: revert `pytest-benchmark` warning skip
gforsyth Jun 11, 2025
a81bd87
chore: add coveragerc for `cudf/benchmarks`
gforsyth Jun 11, 2025
a1e9a71
refactor(custreamz): shift coverage config to coveragerc
gforsyth Jun 11, 2025
be5b121
refactor(tests): move `pylibcudf` tests out of package directory
gforsyth Jun 12, 2025
a47db7a
Merge branch 'branch-25.08' into chore/remove_pytest_pin
gforsyth Jun 12, 2025
708fca1
test(dask): add `filterwarning` to dask serialization test
gforsyth Jun 12, 2025
7a40e01
test(pylibcudf): update coveragerc relative path
gforsyth Jun 12, 2025
f293095
fix(pylibcudf): disable coverage warnings for `pylibcudf`
gforsyth Jun 12, 2025
dd9993f
fix(wheel): update pylibcudf test path for wheels
gforsyth Jun 12, 2025
d5def13
Merge
vyasr Jun 13, 2025
2bac7c1
Merge branch 'branch-25.08' into chore/remove_pytest_pin
vyasr Jun 13, 2025
bd5a079
Expect more test failures
vyasr Jun 16, 2025
c73764f
Merge branch 'branch-25.08' into chore/remove_pytest_pin
vyasr Jun 16, 2025
76f0c8e
Fix
vyasr Jun 17, 2025
93ecae8
More fixes
vyasr Jun 17, 2025
75c66bd
Merge branch 'branch-25.08' into chore/remove_pytest_pin
vyasr Jun 18, 2025
b78606e
Some xfail tests
vyasr Jun 18, 2025
a612ddd
Merge remote-tracking branch 'upstream/branch-25.08' into chore/remov…
vyasr Jun 18, 2025
2875787
Merge branch 'chore/remove_pytest_pin' of github.com:vyasr/cudf into …
vyasr Jun 18, 2025
bf373a7
Fix list
vyasr Jun 18, 2025
ccb18c7
Merge remote-tracking branch 'upstream/branch-25.08' into chore/remov…
vyasr Jun 18, 2025
7952dcb
fix(sh): add/fix `set -euo pipefail` in all shell scripts
gforsyth Jun 24, 2025
1a60b45
Merge branch 'branch-25.08' into chore/remove_pytest_pin
gforsyth Jun 24, 2025
8427088
Merge branch 'branch-25.08' into chore/remove_pytest_pin
vyasr Jun 24, 2025
acfd8de
Merge remote-tracking branch 'upstream/branch-25.08' into chore/remov…
bdice Jun 25, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/run_pylibcudf_pytests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ set -euo pipefail
# It is essential to cd into python/pylibcudf/pylibcudf as `pytest-xdist` + `coverage` seem to work only at this directory level.

# Support invoking run_cudf_pytests.sh outside the script directory
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../python/pylibcudf/pylibcudf/
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../python/pylibcudf/

pytest --cache-clear --ignore="benchmarks" "$@" tests
2 changes: 2 additions & 0 deletions ci/test_cpp.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/bin/bash
# Copyright (c) 2022-2025, NVIDIA CORPORATION.

set -euo pipefail

# Support invoking test_cpp.sh outside the script directory
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../

Expand Down
2 changes: 2 additions & 0 deletions ci/test_cpp_memcheck.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/bin/bash
# Copyright (c) 2023-2025, NVIDIA CORPORATION.

set -euo pipefail

# Support invoking test_cpp.sh outside the script directory
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../

Expand Down
2 changes: 1 addition & 1 deletion ci/test_cudf_polars_polars_tests.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
# Copyright (c) 2024-2025, NVIDIA CORPORATION.

set -eou pipefail
set -euo pipefail

source rapids-init-pip

Expand Down
8 changes: 5 additions & 3 deletions ci/test_narwhals.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
#!/bin/bash
# Copyright (c) 2025, NVIDIA CORPORATION.

set -euo pipefail

# Support invoking test_python_cudf.sh outside the script directory
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../ || exit 1
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../

source rapids-init-pip

Expand All @@ -19,7 +21,7 @@ set +e
rapids-logger "pytest narwhals"
NARWHALS_VERSION=$(python -c "import narwhals; print(narwhals.__version__)")
git clone https://github.com/narwhals-dev/narwhals.git --depth=1 -b "v${NARWHALS_VERSION}" narwhals
pushd narwhals || exit 1
pushd narwhals
rapids-pip-retry install -U -e .

rapids-logger "Check narwhals versions"
Expand Down Expand Up @@ -110,7 +112,7 @@ PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 NARWHALS_DEFAULT_CONSTRUCTORS=pandas python -m
--numprocesses=8 \
--dist=worksteal

popd || exit 1
popd

rapids-logger "Test script exiting with value: $EXITCODE"
exit ${EXITCODE}
6 changes: 4 additions & 2 deletions ci/test_python_cudf.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
#!/bin/bash
# Copyright (c) 2022-2025, NVIDIA CORPORATION.

set -euo pipefail

# Support invoking test_python_cudf.sh outside the script directory
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../;
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../

# Common setup steps shared by Python test jobs
source ./ci/test_python_common.sh test_python_pylibcudf test_python_cudf
Expand All @@ -19,7 +21,7 @@ rapids-logger "pytest pylibcudf"
--junitxml="${RAPIDS_TESTS_DIR}/junit-pylibcudf.xml" \
--numprocesses=8 \
--dist=worksteal \
--cov-config=../.coveragerc \
--cov-config=.coveragerc \
--cov=pylibcudf \
--cov-report=xml:"${RAPIDS_COVERAGE_DIR}/pylibcudf-coverage.xml" \
--cov-report=term
Expand Down
2 changes: 2 additions & 0 deletions ci/test_python_other.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/bin/bash
# Copyright (c) 2022-2025, NVIDIA CORPORATION.

set -euo pipefail

# Support invoking test_python_cudf.sh outside the script directory
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../

Expand Down
4 changes: 2 additions & 2 deletions ci/test_wheel_cudf.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
# Copyright (c) 2023-2025, NVIDIA CORPORATION.

set -eou pipefail
set -euo pipefail

source rapids-init-pip

Expand Down Expand Up @@ -37,7 +37,7 @@ mkdir -p "${RAPIDS_TESTS_DIR}"


rapids-logger "pytest pylibcudf"
pushd python/pylibcudf/pylibcudf/tests
pushd python/pylibcudf/tests
python -m pytest \
--cache-clear \
--numprocesses=8 \
Expand Down
2 changes: 1 addition & 1 deletion ci/test_wheel_cudf_polars.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
# Copyright (c) 2024-2025, NVIDIA CORPORATION.

set -eou pipefail
set -euo pipefail

source rapids-init-pip

Expand Down
2 changes: 1 addition & 1 deletion ci/test_wheel_dask_cudf.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
# Copyright (c) 2023-2025, NVIDIA CORPORATION.

set -eou pipefail
set -euo pipefail

source rapids-init-pip

Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-128_arch-aarch64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ dependencies:
- pydata-sphinx-theme>=0.15.4
- pynvjitlink>=0.0.0a0
- pynvml>=12.0.0,<13.0.0a0
- pytest
- pytest-benchmark
- pytest-cases>=3.8.2
- pytest-cov
- pytest-rerunfailures
- pytest-xdist
- pytest<8
- python-confluent-kafka>=2.8.0,<2.9.0a0
- python-xxhash
- python>=3.10,<3.14
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-128_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@ dependencies:
- pydata-sphinx-theme>=0.15.4
- pynvjitlink>=0.0.0a0
- pynvml>=12.0.0,<13.0.0a0
- pytest
- pytest-benchmark
- pytest-cases>=3.8.2
- pytest-cov
- pytest-rerunfailures
- pytest-xdist
- pytest<8
- python-confluent-kafka>=2.8.0,<2.9.0a0
- python-xxhash
- python>=3.10,<3.14
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ dependencies:
common:
- output_types: [conda, requirements, pyproject]
packages:
- pytest<8
- pytest
- pytest-cov
- pytest-xdist
test_python_cudf_common:
Expand Down
2 changes: 2 additions & 0 deletions python/cudf/.coveragerc
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Configuration file for Python coverage tests
[run]
source = cudf
disable_warnings = module-not-measured
no-data-collected
4 changes: 4 additions & 0 deletions python/cudf/benchmarks/.coveragerc
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Configuration file for Python coverage tests
[run]
disable_warnings = module-not-measured
no-data-collected
Loading
Loading