Skip to content

Adding GH_TOKEN pass-through to summarize job #19143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-25.08
Choose a base branch
from

Conversation

msarahan
Copy link
Contributor

This adds an env var to pass the github token through to the telemetry summary shared action. The token is necessary to check if the base artifact exists. See rapidsai/shared-actions#56 for more information.

The whitespace changes here were introduced from using yq with rapids-reviser to add this field. If the whitespace changes are undesirable, I will revert them.

@msarahan msarahan requested a review from a team as a code owner June 12, 2025 12:55
@msarahan msarahan requested a review from jameslamb June 12, 2025 12:55
@msarahan msarahan added bug Something isn't working non-breaking Non-breaking change labels Jun 12, 2025
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

But yes let's please revert the changes that removed the empty lines between name, on, concurrency, and jobs:

image
image

The other whitespace changes look fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants