Avoid pylibcudf.interop.to_arrow in DataFrame.to_polars in cudf_polars
#19198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
mroeschke
commented
Jun 18, 2025
| @@ -40,6 +40,20 @@ def _create_polars_column_metadata( | |||
| return plc.interop.ColumnMetadata(name=name, children_meta=children_meta) | |||
|
|
|||
|
|
|||
| # This is also defined in pylibcudf.interop | |||
| class _ObjectWithArrowMetadata: | |||
There was a problem hiding this comment.
Yes, exactly. Without this you lose the underlying struct fields. This solution is fine for now while we sort out #18722.
vyasr
approved these changes
Jun 24, 2025
| @@ -40,6 +40,20 @@ def _create_polars_column_metadata( | |||
| return plc.interop.ColumnMetadata(name=name, children_meta=children_meta) | |||
|
|
|||
|
|
|||
| # This is also defined in pylibcudf.interop | |||
| class _ObjectWithArrowMetadata: | |||
There was a problem hiding this comment.
Yes, exactly. Without this you lose the underlying struct fields. This solution is fine for now while we sort out #18722.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR and #18564 are the last PRs removing
pylibcudf.interop.to_arrowincudf_polars.Towards #18534
Checklist