Skip to content

Refactor grid_1d class #19211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 7 commits into from
Jun 27, 2025
Merged

Refactor grid_1d class #19211

rapids-bot merged 7 commits into from
Jun 27, 2025

Conversation

@lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Jun 25, 2025 •
edited
Loading

Description

This Pull Request separates the grid_1d class for use in JIT.
It separates out the device-only functionality into a separate header.
Closes #18216

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lamarrr lamarrr requested a review from a team as a code owner June 25, 2025 09:24
@lamarrr lamarrr requested review from PointKernel and ttnghia June 25, 2025 09:24
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 25, 2025
@lamarrr lamarrr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 25, 2025
@lamarrr lamarrr changed the title refactored grid_1d class Refactor grid_1d class Jun 25, 2025
davidwendt
davidwendt reviewed Jun 25, 2025
View reviewed changes
davidwendt
davidwendt reviewed Jun 25, 2025
View reviewed changes
bdice
bdice reviewed Jun 25, 2025
View reviewed changes
davidwendt
davidwendt reviewed Jun 25, 2025
View reviewed changes
@lamarrr lamarrr requested a review from a team as a code owner June 26, 2025 01:09
@github-actions github-actions bot added the CMake CMake build issue label Jun 26, 2025
@lamarrr lamarrr requested review from bdice and davidwendt June 26, 2025 01:11
mhaseeb123
mhaseeb123 reviewed Jun 26, 2025
View reviewed changes
PointKernel
PointKernel approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should inform the Spark team that this PR will break JNI.

davidwendt
davidwendt reviewed Jun 26, 2025
View reviewed changes
@ttnghia ttnghia added breaking Breaking change and removed non-breaking Non-breaking change labels Jun 26, 2025
@lamarrr lamarrr requested a review from davidwendt June 27, 2025 11:33
@lamarrr
Copy link
Contributor Author

lamarrr commented Jun 27, 2025

/merge

@rapids-bot rapids-bot bot merged commit c493b6e into rapidsai:branch-25.08 Jun 27, 2025
92 of 93 checks passed
@lamarrr lamarrr deleted the grid_1d-jit branch June 27, 2025 13:01
This was referenced Jun 27, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttnghia ttnghia ttnghia approved these changes

@PointKernel PointKernel PointKernel approved these changes

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice Awaiting requested review from bdice

Assignees

@lamarrr lamarrr

Labels

breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA] Refactor grid_1d to allow usage in JITIFY kernels

6 participants

@lamarrr @bdice @ttnghia @PointKernel @mhaseeb123 @davidwendt