Skip to content

Support signed integers and decimals in SUM_WITH_OVERFLOW groupby #19598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Nov 4, 2025
Merged

Support signed integers and decimals in SUM_WITH_OVERFLOW groupby #19598

merged 43 commits into from
Nov 4, 2025

Conversation

@PointKernel
Copy link
Member

@PointKernel PointKernel commented Aug 5, 2025 •
edited
Loading

Description

Closes #19243

This PR updates the SUM_WITH_OVERFLOW groupby implementation to support all signed integer and decimal types, instead of only INT64. It also adds a device-side atomic_add for decimal128, which will help unblock #19251. Note that this is a breaking change: previously, the output value column of SUM_WITH_OVERFLOW groupby was always INT64, but it will now match the input type.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel self-assigned this Aug 5, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 5, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@PointKernel PointKernel changed the title Support signed integers and decimals in SUM_WITH_OVERFLOW Support signed integers and decimals (except decimal128) in SUM_WITH_OVERFLOW groupby Oct 21, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 21, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf-polars Issues specific to cudf-polars pylibcudf Issues specific to the pylibcudf package labels Oct 21, 2025
@PointKernel PointKernel changed the base branch from branch-25.10 to main October 21, 2025 21:09
@PointKernel PointKernel removed Python Affects Python cuDF API. Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf-polars Issues specific to cudf-polars pylibcudf Issues specific to the pylibcudf package labels Oct 21, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Oct 21, 2025
@PointKernel PointKernel added the feature request New feature or request label Oct 21, 2025
davidwendt
davidwendt reviewed Oct 23, 2025
View reviewed changes
davidwendt
davidwendt approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Extra points for decimal128 support.

ttnghia
ttnghia reviewed Oct 27, 2025
View reviewed changes
ttnghia
ttnghia reviewed Oct 27, 2025
View reviewed changes
revans2
revans2 approved these changes Oct 31, 2025
View reviewed changes
@PointKernel PointKernel added breaking Breaking change and removed non-breaking Non-breaking change labels Nov 3, 2025
@PointKernel PointKernel requested a review from ttnghia November 3, 2025 17:43
ttnghia
ttnghia reviewed Nov 3, 2025
View reviewed changes
ttnghia
ttnghia approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on:

@PointKernel
Copy link
Member Author

PointKernel commented Nov 4, 2025

/merge

@rapids-bot rapids-bot bot merged commit fa95da6 into rapidsai:main Nov 4, 2025
140 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Nov 4, 2025
@PointKernel PointKernel deleted the sum-overflow-decimal branch November 4, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@revans2 revans2 revans2 approved these changes

@ttnghia ttnghia ttnghia approved these changes

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@PointKernel PointKernel

Labels

3 - Ready for Review Ready for review by team breaking Breaking change CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Projects

cuDF Python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA] overflow detection for SUM aggregations

4 participants

@PointKernel @revans2 @ttnghia @davidwendt